2023-01-08 19:09:52 +00:00
|
|
|
From efbf3120a8b4bbc66963a696de439501714a1718 Mon Sep 17 00:00:00 2001
|
2023-01-01 21:34:15 +00:00
|
|
|
From: =?UTF-8?q?=C3=A9clairevoyant?=
|
|
|
|
<848000+eclairevoyant@users.noreply.github.com>
|
2023-01-08 19:09:52 +00:00
|
|
|
Date: Sun, 8 Jan 2023 14:05:15 -0500
|
2023-01-01 21:34:15 +00:00
|
|
|
Subject: [PATCH 2/2] i915-vga-arbiter
|
2016-06-13 22:43:18 +00:00
|
|
|
|
|
|
|
---
|
2022-09-29 18:45:39 +00:00
|
|
|
drivers/gpu/drm/i915/display/intel_display.c | 15 ++++++++--
|
2021-01-29 18:03:19 +00:00
|
|
|
drivers/gpu/drm/i915/display/intel_display.h | 1 +
|
2022-09-29 18:45:39 +00:00
|
|
|
drivers/gpu/drm/i915/display/intel_vga.c | 31 ++++++++++++++++++++
|
2021-01-29 18:03:19 +00:00
|
|
|
drivers/gpu/drm/i915/display/intel_vga.h | 4 +++
|
|
|
|
drivers/gpu/drm/i915/i915_params.c | 3 ++
|
|
|
|
drivers/gpu/drm/i915/i915_params.h | 1 +
|
2022-09-29 18:45:39 +00:00
|
|
|
6 files changed, 52 insertions(+), 3 deletions(-)
|
2016-06-13 22:43:18 +00:00
|
|
|
|
2019-10-08 22:51:27 +00:00
|
|
|
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
|
2023-01-01 21:34:15 +00:00
|
|
|
index de77054195c6..507ee4e0d1dc 100644
|
2019-10-08 22:51:27 +00:00
|
|
|
--- a/drivers/gpu/drm/i915/display/intel_display.c
|
|
|
|
+++ b/drivers/gpu/drm/i915/display/intel_display.c
|
2023-01-01 21:34:15 +00:00
|
|
|
@@ -8656,9 +8656,11 @@ int intel_modeset_init_noirq(struct drm_i915_private *i915)
|
2022-09-29 18:45:39 +00:00
|
|
|
|
|
|
|
intel_bios_init(i915);
|
|
|
|
|
2020-12-31 07:44:46 +00:00
|
|
|
- ret = intel_vga_register(i915);
|
|
|
|
- if (ret)
|
2022-09-29 18:45:39 +00:00
|
|
|
- goto cleanup_bios;
|
|
|
|
+ if (!i915_modparams.enable_hd_vgaarb || !HAS_PCH_SPLIT(i915)) {
|
|
|
|
+ ret = intel_vga_register(i915);
|
|
|
|
+ if (ret)
|
|
|
|
+ goto cleanup_bios;
|
|
|
|
+ }
|
|
|
|
|
|
|
|
/* FIXME: completely on the wrong abstraction layer */
|
|
|
|
intel_power_domains_init_hw(i915, false);
|
2023-01-01 21:34:15 +00:00
|
|
|
@@ -8807,6 +8809,12 @@ int intel_modeset_init(struct drm_i915_private *i915)
|
2022-09-29 18:45:39 +00:00
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
+ /*
|
|
|
|
+ * Must do this after fbcon init so that
|
|
|
|
+ * vgacon_save_screen() works during the handover.
|
|
|
|
+ */
|
|
|
|
+ intel_vga_disable_mem(i915);
|
2020-12-31 07:44:46 +00:00
|
|
|
+
|
2022-09-29 18:45:39 +00:00
|
|
|
/* Only enable hotplug handling once the fbdev is fully set up. */
|
|
|
|
intel_hpd_init(i915);
|
|
|
|
intel_hpd_poll_disable(i915);
|
2023-01-01 21:34:15 +00:00
|
|
|
@@ -8977,6 +8985,7 @@ void intel_modeset_driver_remove(struct drm_i915_private *i915)
|
2022-09-29 18:45:39 +00:00
|
|
|
if (!HAS_DISPLAY(i915))
|
|
|
|
return;
|
|
|
|
|
|
|
|
+ intel_vga_enable_mem(i915);
|
2023-01-01 21:34:15 +00:00
|
|
|
flush_workqueue(i915->display.wq.flip);
|
|
|
|
flush_workqueue(i915->display.wq.modeset);
|
2020-02-16 03:17:31 +00:00
|
|
|
|
2020-06-14 01:17:39 +00:00
|
|
|
diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
|
2023-01-01 21:34:15 +00:00
|
|
|
index 884e8e67b17c..90f932db61f0 100644
|
2020-06-14 01:17:39 +00:00
|
|
|
--- a/drivers/gpu/drm/i915/display/intel_display.h
|
|
|
|
+++ b/drivers/gpu/drm/i915/display/intel_display.h
|
2023-01-01 21:34:15 +00:00
|
|
|
@@ -576,6 +576,7 @@ void i830_disable_pipe(struct drm_i915_private *dev_priv, enum pipe pipe);
|
2022-09-29 18:45:39 +00:00
|
|
|
int vlv_get_hpll_vco(struct drm_i915_private *dev_priv);
|
|
|
|
int vlv_get_cck_clock(struct drm_i915_private *dev_priv,
|
2022-03-29 23:56:01 +00:00
|
|
|
const char *name, u32 reg, int ref_freq);
|
2022-09-29 18:45:39 +00:00
|
|
|
+extern void intel_vga_disable_mem(struct drm_i915_private *dev_priv);
|
2022-03-29 23:56:01 +00:00
|
|
|
int vlv_get_cck_clock_hpll(struct drm_i915_private *dev_priv,
|
|
|
|
const char *name, u32 reg);
|
2020-06-14 01:17:39 +00:00
|
|
|
void intel_init_display_hooks(struct drm_i915_private *dev_priv);
|
2020-02-16 03:17:31 +00:00
|
|
|
diff --git a/drivers/gpu/drm/i915/display/intel_vga.c b/drivers/gpu/drm/i915/display/intel_vga.c
|
2022-09-29 18:45:39 +00:00
|
|
|
index b5d058404c14..ad23732a9f21 100644
|
2020-02-16 03:17:31 +00:00
|
|
|
--- a/drivers/gpu/drm/i915/display/intel_vga.c
|
|
|
|
+++ b/drivers/gpu/drm/i915/display/intel_vga.c
|
2022-09-29 18:45:39 +00:00
|
|
|
@@ -45,6 +45,36 @@ void intel_vga_disable(struct drm_i915_private *dev_priv)
|
2020-06-14 01:17:39 +00:00
|
|
|
intel_de_posting_read(dev_priv, vga_reg);
|
2019-10-08 22:51:27 +00:00
|
|
|
}
|
|
|
|
|
2020-02-16 03:17:31 +00:00
|
|
|
+void intel_vga_enable_mem(struct drm_i915_private *dev_priv)
|
2019-10-08 22:51:27 +00:00
|
|
|
+{
|
2021-09-11 06:11:16 +00:00
|
|
|
+ struct pci_dev *pdev = to_pci_dev(dev_priv->drm.dev);
|
2019-10-08 22:51:27 +00:00
|
|
|
+
|
|
|
|
+ /* Enable VGA memory on Intel HD */
|
|
|
|
+ if (i915_modparams.enable_hd_vgaarb && HAS_PCH_SPLIT(dev_priv)) {
|
|
|
|
+ vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO);
|
2022-09-29 18:45:39 +00:00
|
|
|
+ outb(inb(VGA_MIS_R) | (1 << 1), VGA_MIS_W);
|
2019-10-08 22:51:27 +00:00
|
|
|
+ vga_set_legacy_decoding(pdev, VGA_RSRC_LEGACY_IO |
|
|
|
|
+ VGA_RSRC_LEGACY_MEM |
|
|
|
|
+ VGA_RSRC_NORMAL_IO |
|
|
|
|
+ VGA_RSRC_NORMAL_MEM);
|
|
|
|
+ vga_put(pdev, VGA_RSRC_LEGACY_IO);
|
|
|
|
+ }
|
|
|
|
+}
|
|
|
|
+
|
2020-02-16 03:17:31 +00:00
|
|
|
+void intel_vga_disable_mem(struct drm_i915_private *dev_priv)
|
2019-10-08 22:51:27 +00:00
|
|
|
+{
|
2021-09-11 06:11:16 +00:00
|
|
|
+ struct pci_dev *pdev = to_pci_dev(dev_priv->drm.dev);
|
2019-10-08 22:51:27 +00:00
|
|
|
+ /* Disable VGA memory on Intel HD */
|
|
|
|
+ if (i915_modparams.enable_hd_vgaarb && HAS_PCH_SPLIT(dev_priv)) {
|
|
|
|
+ vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO);
|
2022-09-29 18:45:39 +00:00
|
|
|
+ outb(inb(VGA_MIS_R) & ~(1 << 1), VGA_MIS_W);
|
2019-10-08 22:51:27 +00:00
|
|
|
+ vga_set_legacy_decoding(pdev, VGA_RSRC_LEGACY_IO |
|
|
|
|
+ VGA_RSRC_NORMAL_IO |
|
|
|
|
+ VGA_RSRC_NORMAL_MEM);
|
|
|
|
+ vga_put(pdev, VGA_RSRC_LEGACY_IO);
|
|
|
|
+ }
|
|
|
|
+}
|
|
|
|
+
|
2020-02-16 03:17:31 +00:00
|
|
|
void intel_vga_redisable_power_on(struct drm_i915_private *dev_priv)
|
2019-10-08 22:51:27 +00:00
|
|
|
{
|
2020-06-14 01:17:39 +00:00
|
|
|
i915_reg_t vga_reg = intel_vga_cntrl_reg(dev_priv);
|
2022-09-29 18:45:39 +00:00
|
|
|
@@ -53,6 +83,7 @@ void intel_vga_redisable_power_on(struct drm_i915_private *dev_priv)
|
2020-06-14 01:17:39 +00:00
|
|
|
drm_dbg_kms(&dev_priv->drm,
|
2020-08-15 23:38:16 +00:00
|
|
|
"Something enabled VGA plane, disabling it\n");
|
2020-02-16 03:17:31 +00:00
|
|
|
intel_vga_disable(dev_priv);
|
|
|
|
+ intel_vga_disable_mem(dev_priv);
|
2019-10-08 22:51:27 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-02-16 03:17:31 +00:00
|
|
|
diff --git a/drivers/gpu/drm/i915/display/intel_vga.h b/drivers/gpu/drm/i915/display/intel_vga.h
|
2020-06-14 01:17:39 +00:00
|
|
|
index ba5b55b917f0..7e2af7924e99 100644
|
2020-02-16 03:17:31 +00:00
|
|
|
--- a/drivers/gpu/drm/i915/display/intel_vga.h
|
|
|
|
+++ b/drivers/gpu/drm/i915/display/intel_vga.h
|
|
|
|
@@ -15,4 +15,8 @@ void intel_vga_redisable_power_on(struct drm_i915_private *i915);
|
|
|
|
int intel_vga_register(struct drm_i915_private *i915);
|
|
|
|
void intel_vga_unregister(struct drm_i915_private *i915);
|
2019-10-08 22:51:27 +00:00
|
|
|
|
2020-02-16 03:17:31 +00:00
|
|
|
+/* i915 vga arb patch */
|
|
|
|
+void intel_vga_enable_mem(struct drm_i915_private *i915);
|
|
|
|
+void intel_vga_disable_mem(struct drm_i915_private *i915);
|
2019-10-08 22:51:27 +00:00
|
|
|
+
|
2020-02-16 03:17:31 +00:00
|
|
|
#endif /* __INTEL_VGA_H__ */
|
2016-06-13 22:43:18 +00:00
|
|
|
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
|
2023-01-01 21:34:15 +00:00
|
|
|
index d1e4d528cb17..a00cbc6591b0 100644
|
2016-06-13 22:43:18 +00:00
|
|
|
--- a/drivers/gpu/drm/i915/i915_params.c
|
|
|
|
+++ b/drivers/gpu/drm/i915/i915_params.c
|
2023-01-01 21:34:15 +00:00
|
|
|
@@ -154,6 +154,9 @@ i915_param_named_unsafe(invert_brightness, int, 0400,
|
2018-12-12 16:29:25 +00:00
|
|
|
i915_param_named(disable_display, bool, 0400,
|
2020-12-31 07:44:46 +00:00
|
|
|
"Disable display (default: false)");
|
2016-06-13 22:43:18 +00:00
|
|
|
|
2018-02-08 03:41:21 +00:00
|
|
|
+i915_param_named(enable_hd_vgaarb, bool, 0444,
|
2022-09-29 18:45:39 +00:00
|
|
|
+ "Enable support for VGA arbitration on Intel HD IGD. (default: false)");
|
2016-06-13 22:43:18 +00:00
|
|
|
+
|
2022-09-29 18:45:39 +00:00
|
|
|
i915_param_named(memtest, bool, 0400,
|
|
|
|
"Perform a read/write test of all device memory on module load (default: off)");
|
|
|
|
|
2016-06-13 22:43:18 +00:00
|
|
|
diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
|
2023-01-01 21:34:15 +00:00
|
|
|
index 2733cb6cfe09..f21c5b1529cc 100644
|
2016-06-13 22:43:18 +00:00
|
|
|
--- a/drivers/gpu/drm/i915/i915_params.h
|
|
|
|
+++ b/drivers/gpu/drm/i915/i915_params.h
|
2023-01-01 21:34:15 +00:00
|
|
|
@@ -76,6 +76,7 @@ struct drm_printer;
|
2022-09-29 18:45:39 +00:00
|
|
|
param(unsigned int, lmem_size, 0, 0400) \
|
2023-01-01 21:34:15 +00:00
|
|
|
param(unsigned int, lmem_bar_size, 0, 0400) \
|
2018-02-08 03:41:21 +00:00
|
|
|
/* leave bools at the end to not create holes */ \
|
2020-06-14 01:17:39 +00:00
|
|
|
+ param(bool, enable_hd_vgaarb, false, 0600) \
|
|
|
|
param(bool, enable_hangcheck, true, 0600) \
|
|
|
|
param(bool, load_detect_test, false, 0600) \
|
|
|
|
param(bool, force_reset_modeset_test, false, 0600) \
|
2021-01-29 18:03:19 +00:00
|
|
|
--
|
2023-01-01 21:34:15 +00:00
|
|
|
2.38.1
|
2021-01-29 18:03:19 +00:00
|
|
|
|